[HUD] add filter for non-viable strict jobs #7349
Merged
+207
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seemethere
approved these changes
Oct 15, 2025
|
|
||
| // Source of truth for these jobs is in https://github.com/pytorch/pytorch/blob/main/.github/workflows/update-viablestrict.yml#L26 | ||
| export const VIABLE_STRICT_BLOCKING_JOBS: RepoViableStrictBlockingJobsMap = { | ||
| "pytorch/pytorch": [/pull/i, /trunk/i, /lint/i, /linux-aarch64/i], |
There was a problem hiding this comment.
This might be hard to maintain.
I'm curious if we can have this be populated somewhere in clickhouse and we can just pull it from there.
It's fine for a first pass but we should make a TODO / issue about revising it to do the right thing
There was a problem hiding this comment.
I totally agree, but it was hardcoded this way before this PR, I just moved it to the different file.
jeanschmidt
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a filter to hide non-viable strict jobs:
in grouped view makes the border more obvious / adds tooltip info:
syncs the viable-strict logic with the source (per the comment in the original implementation)
Note: we really need to centralize the config for viable/strict, but that's out of the scope of this PR.