Skip to content

Revert "Cleanup VS 2019 refs in pytorch (#145863)" #152613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented May 1, 2025

This reverts commit b45e6fa.

revert PRs:
#145863
#145319

Copy link

pytorch-bot bot commented May 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152613

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit e5b621d with merge base 4c11b26 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR release notes: releng release notes category labels May 1, 2025
@xuhancn xuhancn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks ciflow/binaries Trigger all binary build and upload jobs on the PR labels May 1, 2025
@xuhancn xuhancn requested review from malfet and atalman May 2, 2025 05:37
@xuhancn xuhancn marked this pull request as ready for review May 2, 2025 05:37
@xuhancn xuhancn requested a review from a team as a code owner May 2, 2025 05:37
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 2, 2025
@atalman atalman added this to the 2.7.1 milestone May 7, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented May 7, 2025

@xuhancn Can you please resolve conflict on this PR and we can land

@xuhancn
Copy link
Collaborator Author

xuhancn commented May 7, 2025

@atalman please hold on, it seems MSFT found a way to fix the illegal instrunction on VS2022: #145702 (comment)

@xuhancn xuhancn force-pushed the xu_roll_back_vs2019 branch from 56490c8 to e5b621d Compare May 10, 2025 14:38
@xuhancn xuhancn added skip-url-lint and removed ciflow/xpu Run XPU CI tasks labels May 10, 2025
@xuhancn
Copy link
Collaborator Author

xuhancn commented May 10, 2025

@pytorchbot drci

@xuhancn
Copy link
Collaborator Author

xuhancn commented May 10, 2025

@pytorchbot -f "ignore no related xpu uts"

Copy link

pytorch-bot bot commented May 10, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'ignore no related xpu uts' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@xuhancn
Copy link
Collaborator Author

xuhancn commented May 10, 2025

@pytorchbot merge -f "ignore no related xpu uts"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn
Copy link
Collaborator Author

xuhancn commented May 10, 2025

@atalman please don't forget to cherry-pick this PR to release/2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: releng release notes category skip-url-lint triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants