-
Notifications
You must be signed in to change notification settings - Fork 24.1k
Revert "Cleanup VS 2019 refs in pytorch (#145863)" #152613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152613
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Unrelated FailureAs of commit e5b621d with merge base 4c11b26 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@xuhancn Can you please resolve conflict on this PR and we can land |
@atalman please hold on, it seems MSFT found a way to fix the illegal instrunction on VS2022: #145702 (comment) |
56490c8
to
e5b621d
Compare
@pytorchbot drci |
@pytorchbot -f "ignore no related xpu uts" |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot merge -f "ignore no related xpu uts" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@atalman please don't forget to cherry-pick this PR to |
This reverts commit b45e6fa.
revert PRs:
#145863
#145319