Roctracer-sdk internal #1155
Open
Roctracer-sdk internal #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Supersedes pytorch#1050 Convert to using rocprofiler-sdk instead of roctracer for collecting hip api calls and AMD gpu activity. Reuses most existing roctracer infrastructure with a name for name replacement. Simultaneous support for both roctracer and rocprofiler-sdk was deemed impractical. This would require a whole new set of #ifdefs, a major refactor of the roctracer code, and additional build support. Even then, only one could be active at a time (and you wouldn't want both active). In homage to the abandoned refactor, RocLogger.cpp/h were created to contain the rocprofbase classes and the api filter. Roctracer has no established end date. Rocprofiler-sdk is in rocm_3.1 forward. This will create a dependency where (newest kineto on old rocm) and (old kineto on newest rocm) could fail to build with AMD gpu support. That window is already over 1 year wide. Pull Request resolved: pytorch#1128 Reviewed By: malfet, aaronenyeshi Differential Revision: D82773951 Pulled By: sraikund16
Differential Revision: D84165235
|
@sraikund16 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84165235. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D84165235