Skip to content

Give @claude reviews up to 2 hours before the job times out - #24842

Merged
shoumikhin merged 1 commit into
pytorch:mainfrom
shoumikhin:claude-code-timeout-120
Nov 10, 2026
Merged

shoumikhin merged 1 commit into
pytorch:mainfrom
shoumikhin:claude-code-timeout-120

Conversation

@shoumikhin

Copy link
Copy Markdown
Contributor

Max-effort reviews (effort=max) run a panel of reviewers and then fact-check their findings. On large PRs this does not fit in the default 60-minute job timeout. In the last 2 weeks, 4 of 44 max-effort reviews were cancelled at exactly 60 minutes, before posting anything, and 3 more finished within 5 minutes of the limit. Default-effort reviews take about 10 minutes and are not affected.

This sets timeout_minutes: 120 for the Claude Code job.

Max-effort reviews (effort=max) run a panel of reviewers and then
fact-check their findings. On large PRs this does not fit in the
default 60-minute job timeout of the reusable workflow, so the job is
cancelled before it posts anything. Default-effort reviews take about
10 minutes and are not affected.

Set timeout_minutes: 120 for the Claude Code job.

Signed-off-by: Anthony Shoumikhin <anthony@shoumikh.in>
@shoumikhin shoumikhin added topic: not user facing release notes: none Do not include this in the release notes labels Nov 10, 2026
Copilot AI balanced review requested due to automatic review settings November 10, 2026 15:36
@pytorch-bot

pytorch-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24842

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 7f2096b with merge base f8373ec (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@shoumikhin
shoumikhin merged commit c82dc59 into pytorch:main Nov 10, 2026
198 of 210 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants