Repository navigation
Arm backend: Fix Arm PT2E quantization with export guards - #24837
Merged
Merged
Conversation
PyTorch 2.15 adds a _guards_fn call_module node to ExportedProgram.module() by default. This causes Arm's PT2E quantization passes to fail with ExportPassBaseError: call_module is not supported. Changes: Remove unused _guards_fn nodes before Arm quantization annotation. Preserve unrelated call_module nodes and reject unsafe guard removal. Add regression tests for guarded and unguarded exports. This allows prepare_pt2e(ep.module(), quantizer) to work without requiring check_guards=False in user code. Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com> Change-Id: Ie29d1f97edb1890db718b79a9147e9e7708461d1
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24837
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 538f541 with merge base 5af315a ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
oscarandersson8218
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch 2.15 adds a _guards_fn call_module node to ExportedProgram.module() by default. This causes Arm's PT2E quantization passes to fail with
ExportPassBaseError: call_module is not supported.
Changes:
Remove unused _guards_fn nodes before Arm quantization annotation.
Preserve unrelated call_module nodes and reject unsafe guard removal.
Add regression tests for guarded and unguarded exports.
This allows prepare_pt2e(ep.module(), quantizer) to work
without requiring check_guards=False in user code.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani