Repository navigation
[ET-VK][unary] Compute vec4 leaky_relu with a single mix - #24824
Merged
Merged
Conversation
Pull Request resolved: #24813 ## Ulterior Motive RIFE's conv + residual + LeakyReLU blocks now lower to `et_vk.conv2d.with_epilogue`, which replaces the explicit `conv2d_residual_lrelu` / `conv2d_lrelu` ops. On Galaxy S23, direct convs with the generic epilogue ran 5–10% slower than with hardcoded `leaky_relu(conv + residual)` math. The leaky_relu formula accounts for most of that gap. ## Rationale **What**: `leaky_relu(vec4)` now selects between `x` and `x * slope` with one `mix`. The scalar overload, now unused, is removed. **Why**: The old form evaluated `x * (float(x > 0) + slope * float(x <= 0))` once per component: two compares, two conversions and two multiplies per lane. The conv2d epilogue applies it to every output texel, and the unary operators share the header. ## Details - Outputs are identical for finite slopes, including at ±0, ±inf and NaN. - On the RIFE residual configuration, the conv2d SPIR-V drops to: - Adreno: about 96 ALU instructions; - Mali-G715: 0.5 arithmetic cycles, about 6%. Differential Revision: [D130740220](https://our.internmc.facebook.com/intern/diff/D130740220/) ghstack-source-id: 469036232
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24824
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 8 PendingAs of commit 54d587b with merge base e5ffebe ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
SS-JIA
approved these changes
Nov 10, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #24813 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/700/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/700/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/699/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/700/orig
Differential Revision: D130740220
@diff-train-skip-merge