Repository navigation
[executorch][cuda] Run CudaExecutor steps from prepared embeddings - #24063
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24063
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit bd6aafe with merge base 5e8d11b ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 21, 2026
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
metascroy
approved these changes
Oct 21, 2026
This was referenced Oct 22, 2026
Gasoonjia
temporarily deployed
to
upload-benchmark-results
October 22, 2026 16:23 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Gasoonjia
temporarily deployed
to
upload-benchmark-results
October 23, 2026 17:28 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
meta-codesync Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
…ckends Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #24076 * #24107 * #24075 * #24074 * #24073 * #24072 * #24066 * #24065 * #24064 * #24063 * __->__ #24062 Move the MLX executor's EngineEmbeddings (vision encoder + embed_text + MuseGlimmerMaterializer) into runtime/model_embeddings so the CUDA batching executors can materialize prepared image inputs the same way. MLX behavior is unchanged; it now holds a MuseGlimmerModelEmbeddings. Differential Revision: D125987290 Pull Request resolved: #24062
meta-codesync Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #24076 * #24107 * #24075 * #24074 * #24073 * #24072 * #24066 * #24065 * __->__ #24064 * #24063 * #24062 export_cuda_batching optionally adds vision_encoder, embed_text and a dynamic forward_from_embeddings over the same off-graph KV contract, and writes pos_embed.bin next to the program. Differential Revision: D125987292 Pull Request resolved: #24064
meta-codesync Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #24076 * #24107 * #24075 * #24074 * #24073 * #24072 * #24066 * __->__ #24065 * #24064 * #24063 * #24062 The CUDA backend factory builds the image preparation spec from the shared embeddings engine, and serve_batching passes --pos-embed-path through, so image requests are served on regular CUDA batching. Differential Revision: D125987293 Pull Request resolved: #24065
meta-codesync Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #24076 * #24107 * #24075 * #24074 * #24073 * #24072 * __->__ #24066 * #24065 * #24064 * #24063 * #24062 The CUDA DFlash executor accepts prepared image inputs on admission; image steps run the target from embeddings, then hidden taps and drafting proceed as for tokens. Differential Revision: D125987295 Pull Request resolved: #24066
Gasoonjia
added a commit
that referenced
this pull request
Nov 5, 2026
…24653) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #24063 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/86/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/86/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/85/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/86/orig Differential Revision: [D125987291](https://our.internmc.facebook.com/intern/diff/D125987291/) @diff-train-skip-merge Co-authored-by: gasoonjia <gasoonjia@icloud.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Steps that carry a prepared (image) input run forward_from_embeddings with the
materialized rows; token-only steps keep the static forward_{N} methods and
their CUDA graphs. SessionTable packs prepared rows as placeholders so the
cache still plans their positions.
Differential Revision: D125987291