Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Oct 31, 2025

Signed-off-by: [email protected]
Change-Id: I7915f4560fe0b2b1c949e21139612dae8acb8ee9

@perheld perheld requested a review from digantdesai as a code owner October 31, 2025 11:32
@perheld perheld added ciflow/trunk module: arm Issues related to arm backend release notes: none Do not include this in the release notes labels Oct 31, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15488

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit df38a6c with merge base a11d555 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2025
@zingo
Copy link
Collaborator

zingo commented Oct 31, 2025

@digantdesai this touch a lot of files but only fixing mypy problem, do you see a need to check it internally?

Signed-off-by: [email protected]
Change-Id: I7915f4560fe0b2b1c949e21139612dae8acb8ee9
@perheld perheld force-pushed the ph-mypy-ops-passes-test branch from 4827b13 to df38a6c Compare November 3, 2025 10:16
@zingo
Copy link
Collaborator

zingo commented Nov 3, 2025

Hi @SS-JIA Im not sure if you want to test this internally or not if so let us know, it just changes small stuff in many files but does not move code around or add/remove files so we consider it safe but try to alert when when do "larger" changes.

Copy link
Contributor

@SS-JIA SS-JIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok I think. Just adds typing annotations, etc. so shouldn't break anything. LGTM!

@zingo zingo merged commit 135e3b6 into pytorch:main Nov 3, 2025
439 of 443 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants