Skip to content

Conversation

@pssrawat
Copy link
Contributor

Summary:
Curently dim_order_for_stride() checks if any stride is 0, and fails if so. N7613577 shows a min repro from factorized joiner usecase with symbolic stride, where this check fails: P2015309933
This diff skips the assert for symbolic strides.

Differential Revision: D85875885

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15472

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 4 Unrelated Failures

As of commit 87dc06d with merge base 55452bf (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 30, 2025

@pssrawat has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85875885.

@pssrawat pssrawat added the release notes: none Do not include this in the release notes label Oct 30, 2025
pssrawat added a commit to pssrawat/executorch that referenced this pull request Oct 31, 2025
…15472)

Summary:

Curently dim_order_for_stride() checks if any stride is 0, and fails if so. N7613577 shows a min repro from factorized joiner use case with symbolic stride, where this check fails: P2015309933
This failure is blocking us from migrating live translation models to ExecuTorch.
This diff fixes the block by skipping the assert for symbolic strides.

Differential Revision: D85875885
pssrawat added a commit to pssrawat/executorch that referenced this pull request Nov 3, 2025
…15472)

Summary:

Curently dim_order_for_stride() checks if any stride is 0, and fails if so. N7613577 shows a min repro from factorized joiner use case with symbolic stride, where this check fails: P2015309933
This failure is blocking us from migrating live translation models to ExecuTorch.
This diff fixes the block by skipping the assert for symbolic strides.

Reviewed By: angelayi

Differential Revision: D85875885
@pssrawat pssrawat requested a review from angelayi November 3, 2025 23:12
…15472)

Summary:

Curently dim_order_for_stride() checks if any stride is 0, and fails if so. N7613577 shows a min repro from factorized joiner use case with symbolic stride, where this check fails: P2015309933
This failure is blocking us from migrating live translation models to ExecuTorch.
This diff fixes the block by skipping the assert for symbolic strides.

Reviewed By: angelayi

Differential Revision: D85875885
@pssrawat pssrawat merged commit 73b6918 into pytorch:main Nov 4, 2025
132 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants