Metal backend: Implement the AOTI MPS shim #15022
Open
+658
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15022
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
❌ 3 New FailuresAs of commit 5dfcd4f with merge base 896178e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 10, 2025
meta-cla
bot
added
the
CLA Signed
manuelcandales
requested review from
larryliu0820 and
mergennachin
and removed request for
cccclai and
shoumikhin
Comment on lines
+453
to
+464
| auto src_mtl_buffer = (id<MTLBuffer>)src_buffer; | ||
| auto dst_mtl_buffer = (id<MTLBuffer>)dst_buffer; | ||
|
|
||
| uint8_t* src_contents = static_cast<uint8_t*>([src_mtl_buffer contents]); | ||
| uint8_t* dst_contents = static_cast<uint8_t*>([dst_mtl_buffer contents]); | ||
|
|
||
| if (!src_contents || !dst_contents) { | ||
| ET_LOG(Error, "aoti_torch_mps_copy_buffer: Failed to get buffer contents"); | ||
| return Error::Internal; | ||
| } | ||
|
|
||
| memcpy(dst_contents + dst_offset, src_contents + src_offset, data_size); |
There was a problem hiding this comment.
aoti_torch_mps_free and aoti_torch_mps_memcpy expect contents ptr, but aoti_torch_mps_copy_buffer expects MTLBuffer objects. Is this intentional?
Isn't it something like this?
auto src_it = ptr_to_mtl_buffer.find(src_buffer);
auto dst_it = ptr_to_mtl_buffer.find(dst_buffer);
if (src_it == ptr_to_mtl_buffer.end()) {
ET_LOG(Error, "aoti_torch_mps_copy_buffer: src_buffer %p not found", src_buffer);
return Error::InvalidArgument;
}
if (dst_it == ptr_to_mtl_buffer.end()) {
ET_LOG(Error, "aoti_torch_mps_copy_buffer: dst_buffer %p not found", dst_buffer);
return Error::InvalidArgument;
}
id<MTLBuffer> src_mtl_buffer = src_it->second;
id<MTLBuffer> dst_mtl_buffer = dst_it->second;
ETMetalStream* stream = getCurrentMetalStream();
stream->copy(src_mtl_buffer, dst_mtl_buffer, data_size, src_offset, dst_offset, SyncType::NONE);
Comment on lines
+416
to
+423
| id<MTLBuffer> subBuffer = [device newBufferWithBytesNoCopy:buffer_pointer + constant_offset | ||
| length:data_size | ||
| options:MTLResourceCPUCacheModeWriteCombined | MTLResourceStorageModeShared | ||
| deallocator:nil]; | ||
|
|
||
| if (constant_offset != 0) { | ||
| ptr_to_mtl_buffer[buffer_pointer + constant_offset] = subBuffer; // Map contents to buffer | ||
| } |
There was a problem hiding this comment.
Why do you need this at all? subBuffer doesn't seem to be used anywhere
| } | ||
| } | ||
|
|
||
| AOTITorchError aoti_torch_mps_get_kernel_function( |
There was a problem hiding this comment.
Call @autoreleasepool?
| } | ||
| } | ||
|
|
||
| AOTITorchError aoti_torch_mps_start_encoding( |
There was a problem hiding this comment.
call @autoreleasepool
| // Pure C dispatch functions - array versions | ||
| AOTITorchError aoti_torch_mps_dispatch_array( | ||
| AOTIMetalKernelFunctionHandle func, | ||
| const uint64_t* length, |
There was a problem hiding this comment.
Validate length != nullptr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: