-
Notifications
You must be signed in to change notification settings - Fork 680
Make _get_program_from_buffer work for bundled programs take 2 #14503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# Copyright (c) Meta Platforms, Inc. and affiliates. | ||
# All rights reserved. | ||
# Copyright 2025 Arm Limited and/or its affiliates. | ||
# | ||
# This source code is licensed under the BSD-style license found in the | ||
# LICENSE file in the root directory of this source tree. | ||
|
@@ -37,6 +38,10 @@ target_compile_options( | |
# Unix builds, but we also build on Windows where it's ignored | ||
|
||
# Link against required libraries | ||
if(TARGET bundled_program) | ||
target_compile_definitions(selective_build PRIVATE -DET_BUNDLE_IO) | ||
target_link_libraries(selective_build PRIVATE bundled_program) | ||
Comment on lines
+42
to
+43
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You also wanna change the targets.bzl file too I added a CI to build buck target for selective_build For future reference, here's how you can download buck:
Once you have the buck file, you can do something like this:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had a look and the bundled_program seems to have multiple targets There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Erik-Lundell -- no need to bifurcate on aten vs not. You can add dependency on Historically, |
||
endif() | ||
target_link_libraries(selective_build PRIVATE executorch_core program_schema) | ||
|
||
# Install the module | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you check EXECUTORCH_BUILD_DEVTOOLS?
Something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with this since it is done that way on L754 in top-level CMakeLists.txt. Is there a benefit in additionally checking the flag or just to be on the safe side?