Skip to content

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14368 by @Ninja91
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/Ninja91/19/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/Ninja91/19/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/Ninja91/19/orig
@diff-train-skip-merge

Pull Request resolved: #14368

Add U55 and U85 16A8W quantization tests for linear operations following the pattern established in D80510628 for mul operations.

This adds test coverage for 16A8W (16-bit activations, 8-bit weights) quantization on both Ethos-U55 and Ethos-U85 platforms for linear operations. Both tests are marked with xfail annotations due to the known Vela compilation issue where int16 linear operations fail with "Conv2D Invalid arguments" error.

The tests follow the same structure as the existing 16A8W TOSA test but target specific hardware platforms:
- test_linear_16a8w_u55_INT16: Tests on U55 with rank1 data
- test_linear_16a8w_u85_INT16: Tests on U85 with both rank1 and rank4 data

Both tests use the same symmetric A16W8 quantization configuration and are properly decorated with platform-specific skip conditions (XfailIfNoCorstone300/320) and pytest xfail markers referencing GitHub issue 13947.

Addresses: #13729
ghstack-source-id: 310981820
@exported-using-ghexport

Differential Revision: [D82618039](https://our.internmc.facebook.com/intern/diff/D82618039/)
Copy link

pytorch-bot bot commented Sep 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14453

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit af100df with merge base 07d1092 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Ninja91 Ninja91 self-requested a review September 21, 2025 03:08
@Ninja91 Ninja91 merged commit f801c4f into main Sep 21, 2025
126 of 129 checks passed
@Ninja91 Ninja91 deleted the gh/Ninja91/19/orig branch September 21, 2025 03:10
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#14368 by
@Ninja91
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/Ninja91/19/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/Ninja91/19/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/Ninja91/19/orig
@diff-train-skip-merge

Co-authored-by: Nitin Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants