Skip to content

Update ReplaceConvolutionOptionalArgsWithConcreteArgsPass to work with cadence.convolution #14445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2025
Merged

Update ReplaceConvolutionOptionalArgsWithConcreteArgsPass to work with cadence.convolution #14445

merged 1 commit into from
Sep 20, 2025

Conversation

ethansfng
Copy link
Contributor

Summary: ReplaceConvolutionOptionalArgsWithConcreteArgsPass runs after ReplaceAtenConvolutionWithCadenceConvolutionPass so ReplaceConvolutionOptionalArgsWithConcreteArgsPass should be configured to run on a cadence.convolution not aten.convolution

Differential Revision: D82842567

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14445

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 906d85b with merge base 3f17a93 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2025
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82842567.

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ethansfng @facebook-github-bot
Update ReplaceConvolutionOptionalArgsWithConcreteArgsPass to work wit…
906d85b 
…h cadence.convolution (pytorch#14445)

Summary:

ReplaceConvolutionOptionalArgsWithConcreteArgsPass runs after ReplaceAtenConvolutionWithCadenceConvolutionPass so ReplaceConvolutionOptionalArgsWithConcreteArgsPass should be configured to run on a cadence.convolution not aten.convolution

Reviewed By: zonglinpeng

Differential Revision: D82842567
@facebook-github-bot
Copy link
Contributor

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating diff in D82842567.

@facebook-github-bot facebook-github-bot merged commit fd04fe0 into pytorch:main Sep 20, 2025
126 of 128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonglinpeng zonglinpeng zonglinpeng approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethansfng @facebook-github-bot @zonglinpeng