Make _get_program_from_buffer work for bundled programs #14435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some cmake to only do this if executorch is built with bundleio. codegen/tools subdirectory needs to be moved in top-level CmakeLists.txt to have access to the bundled_program target. Signed-off-by: Erik Lundell <[email protected]> Change-Id: Ic953bdfd5223eb835e46150bde19b08b082e8444
Signed-off-by: Erik Lundell <[email protected]> Change-Id: Ib7fbdb7190312320d73a937bc285db7140d2bb1a
Erik-Lundell
requested review from
larryliu0820,
lucylq,
kirklandsign,
digantdesai and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14435
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 93d51bb with merge base 246009b ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some cmake to only do this if executorch is built with bundleio.
codegen/tools subdirectory include needs to be moved in top-level CmakeLists.txt
to have access to the bundled_program target.
Follow-up patch to enable the fix in arm backend.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218