Skip to content

Use fbjni 0.7.0 and set ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON #14418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

Use fbjni 0.7.0 and set ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON #14418

merged 1 commit into from
Sep 18, 2025

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Sep 18, 2025 •
edited
Loading

Summary

Partial fix for #11597

We can upgrade to NDK 28 when fbjni upgrades.

Test plan

CI

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14418

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Pending

As of commit 8b52ca2 with merge base 4d0961e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2025
@kirklandsign kirklandsign marked this pull request as ready for review September 18, 2025 21:34
@kirklandsign kirklandsign added the release notes: android Android Java and JNI code label Sep 18, 2025
@kirklandsign kirklandsign merged commit 0f22062 into main Sep 18, 2025
137 of 140 checks passed
@kirklandsign kirklandsign deleted the ndk-fbjni branch September 18, 2025 22:10
@kirklandsign
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c critical

pytorchbot pushed a commit that referenced this pull request Sep 18, 2025
@kirklandsign @pytorchbot
Use fbjni 0.7.0 and set ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON (#14418)
4a64d8e 
Partial fix for #11597

We can upgrade to NDK 28 when fbjni upgrades.

(cherry picked from commit 0f22062)
@pytorchbot
Copy link
Collaborator

Cherry picking #14418

The cherry pick PR is at #14420 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: android Android Java and JNI code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirklandsign @pytorchbot @GregoryComer