Skip to content

Arm backend: Enable pytest VKML op unit testing in ciflow/trunk - #14109

Merged
mansnils merged 12 commits into
pytorch:mainfrom
mansnils:ci
Nov 14, 2025
Merged

Arm backend: Enable pytest VKML op unit testing in ciflow/trunk#14109
mansnils merged 12 commits into
pytorch:mainfrom
mansnils:ci

Conversation

@mansnils

@mansnils mansnils commented Sep 9, 2025 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator

Enable VKML op unit test for Arm backend.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@mansnils
Arm backend: Enable pytest VKML op unit testing in ciflow/trunk
ffcb292 
Change-Id: I58fa82ba8c55103c934a1a0b309d6e7c1327d35e
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Sep 9, 2025
@pytorch-bot

pytorch-bot Bot commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14109

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit f36640a with merge base 8c48a76 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@zingo

zingo commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Ouch, all jobs timedout installing/building the deps :(
Until we get precompiled deps this might need to be pre-build in the docker.
Maybe the Vulkan backend already have a solution to copy/clone?

@mansnils mansnils added the release notes: arm Changes to the ARM backend delegate label Oct 24, 2025
@mansnils

mansnils commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator Author

Missing building executor runner for VKML - will add it.

@mansnils
mansnils requested a review from cccclai as a code owner November 7, 2025 12:56
@mansnils

mansnils commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator Author

Missing building executor runner for VKML - will add it.

Done

@mansnils

mansnils commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator Author

Let's see if [trunk / test-arm-backend (test_pytest_ops_vkml) pass with linux.g5.4xlarge.nvidia.gpu instead of linux.2xlarge.memory runner just as a quick test.

@mansnils

mansnils commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator Author

The docker update probably need to merge into a separate PR first.

@mansnils

mansnils commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator Author

The docker update probably need to merge into a separate PR first.

#15812

@mansnils
mansnils merged commit 4178419 into pytorch:main Nov 14, 2025
723 of 731 checks passed
@zingo

zingo commented Nov 15, 2025

Copy link
Copy Markdown
Collaborator

After this was merged one Arm job times out all the time :(
See trunk / test-arm-backend (test_pytest_ops_ethosu_fvp) on
https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=arm-backend

zingo added a commit that referenced this pull request Nov 15, 2025
@zingo
Revert "Arm backend: Enable VKML unit testing in ciflow/trunk (#14109)"
ffa68b3 
This reverts commit 4178419.
@zingo zingo mentioned this pull request Nov 15, 2025
Merged
@zingo

zingo commented Nov 15, 2025

Copy link
Copy Markdown
Collaborator

Creating a revert PR #15841

This was referenced Nov 15, 2025
Merged
Merged
Merged
Merged
zingo added a commit that referenced this pull request Nov 15, 2025
@zingo
Revert "Arm backend: Enable pytest VKML op unit testing in ciflow/tru…
0c0cee5 
…nk" (#15841)

Reverts #14109

This caused timeout on arm ops unit tests

cc @freddan80 @per @oscarandersson8218 @digantdesai
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
@mansnils @zingo @jirioc
Arm backend: Enable VKML unit testing in ciflow/trunk (pytorch#14109)
cbb9ad7 
Enable VKML op unit test for Arm backend.

Co-authored-by: Zingo Andersen <zingo.andersen@arm.com>
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
@zingo @jirioc
Revert "Arm backend: Enable pytest VKML op unit testing in ciflow/tru…
2dc447a 
…nk" (pytorch#15841)

Reverts pytorch#14109

This caused timeout on arm ops unit tests

cc @freddan80 @per @oscarandersson8218 @digantdesai
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes
@cccclai cccclai Awaiting requested review from cccclai

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mansnils @zingo @digantdesai