Skip to content

append to CMAKE_PREFIX_PATH instead of setting executorch_DIR #12618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: gh/swolchok/515/head
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

I think the _DIR mechanism is too low-level -- it helps find , but not any dependencies that also installed next to itself. CMAKE_PREFIX_PATH does both.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jul 17, 2025

Copy link

pytorch-bot bot commented Jul 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12618

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit f5bcdcc with merge base 00b02f1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added 2 commits July 18, 2025 14:17
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants