Skip to content

Arm backend: Reenable test_fuse_const_ops_tosa_BI #10847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Arm backend: Reenable test_fuse_const_ops_tosa_BI #10847

wants to merge 1 commit into from
+8 −8

Conversation

martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented May 13, 2025 •
edited by pytorch-bot bot
Loading

The fusing of constant ops now works for TOSA BI again.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Arm backend: Reenable test_fuse_const_ops_tosa_BI
bd1c979 
The fusing of constant ops now works for TOSA BI again.

Change-Id: I7f6d24dfc56b2cc3f5de6107c143be4f249c720b
@martinlsm martinlsm requested review from tom-arm and maddun01 May 13, 2025 09:32
@martinlsm martinlsm requested a review from digantdesai as a code owner May 13, 2025 09:32
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10847

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit bd1c979 with merge base 7993bb2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label May 13, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@zingo
Copy link
Collaborator

zingo commented May 13, 2025 •
edited
Loading

@martinlsm l this seem to have got a merge conflict :( and probably need a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-arm tom-arm Awaiting requested review from tom-arm

@maddun01 maddun01 Awaiting requested review from maddun01

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinlsm @zingo @facebook-github-bot