Skip to content

Arm backend: Merge decompose/convert meandim pass #10844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented May 13, 2025

This change has multiple benifits:

  • Cleaner arm_pass_manager
  • Use more efficient avgpool2d decompostion in more cases
  • Fixes a bug decomposing to avgpool for rank != 4

Note that symmetric_io_quantization is required for the unittests resulting in only a avgpool op becuase of the way avgpool is annotated.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

This change has multiple benifits:
- Cleaner arm_pass_manager
- Use more efficient avgpool2d decompostion in more cases
- Fixes a bug decomposing to avgpool for rank != 4

Note that symmetric_io_quantization is required for the unittests
resulting in only a avgpool op becuase of the way avgpool is
annotated.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: Ic5aefa8673661ee0c38503c0522b0590d310b341
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 13, 2025
Copy link

pytorch-bot bot commented May 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10844

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit a7a25c2 with merge base dcd25eb (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@AdrianLundell AdrianLundell added the release notes: arm Changes to the ARM backend delegate label May 13, 2025
@zingo
Copy link
Collaborator

zingo commented May 13, 2025

@AdrianLundell this seem to have got a merge conflict :( and probably need a rebase.

@zingo zingo merged commit e13b086 into pytorch:main May 13, 2025
180 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants