Add floatValue to ExecuTorch value #10823

f-meloni · 2025-05-12T20:38:50Z

Summary:
I think we can have an utility to return floats back.
I would not create a new tag, but just use the double value and return it as float if the user needs float

Differential Revision: D74603334

cc @mergennachin @byjlw

pytorch-bot · 2025-05-12T20:38:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10823

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[PREEMPTIVE] Removal of ephemeral variants on scale-config.yml

⏳ No Failures, 4 Pending

As of commit 4120a69 with merge base e7ec913 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-05-12T20:39:12Z

This pull request was exported from Phabricator. Differential Revision: D74603334

f-meloni · 2025-05-12T20:51:39Z

@pytorchbot label "module: user experience"

Summary: I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

facebook-github-bot · 2025-05-12T20:54:48Z

This pull request was exported from Phabricator. Differential Revision: D74603334

shoumikhin · 2025-05-12T21:04:49Z

extension/apple/ExecuTorch/Exported/ExecuTorchValue.h

@@ -40,6 +40,8 @@ typedef NSInteger ExecuTorchIntegerValue
    NS_SWIFT_BRIDGED_TYPEDEF NS_SWIFT_NAME(IntegerValue);
 typedef double ExecuTorchDoubleValue
    NS_SWIFT_BRIDGED_TYPEDEF NS_SWIFT_NAME(DoubleValue);
+    typedef double ExecuTorchFloatValue


Suggested change

typedef double ExecuTorchFloatValue

typedef float ExecuTorchFloatValue

Should this be float?

shoumikhin · 2025-05-12T21:05:23Z

extension/apple/ExecuTorch/Exported/ExecuTorchValue.h

+/**
+ * Returns YES if the value is a float.
+ *
+ * @return A BOOL indicating whether the value is a double.


Suggested change

* @return A BOOL indicating whether the value is a double.

* @return A BOOL indicating whether the value is a float.

extension/apple/ExecuTorch/Exported/ExecuTorchValue.mm

shoumikhin · 2025-05-12T21:09:18Z

extension/apple/ExecuTorch/Exported/ExecuTorchValue.h

+ * The integer value if the tag is ExecuTorchValueTagFloat.
+ *
+ * @return An NSInteger representing the float value.


Suggested change

* The integer value if the tag is ExecuTorchValueTagFloat.

*

* @return An NSInteger representing the float value.

* The float value if the tag is ExecuTorchValueTagDouble.

*

* @return A float representing the float value.

Summary: I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

facebook-github-bot · 2025-05-13T12:59:05Z

This pull request was exported from Phabricator. Differential Revision: D74603334

facebook-github-bot · 2025-05-13T13:00:36Z

This pull request was exported from Phabricator. Differential Revision: D74603334

Summary: Pull Request resolved: pytorch#10823 I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

Summary: I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

facebook-github-bot · 2025-05-13T14:24:30Z

This pull request was exported from Phabricator. Differential Revision: D74603334

shoumikhin · 2025-05-13T14:27:14Z

extension/apple/ExecuTorch/Exported/ExecuTorchValue.h

@@ -40,6 +40,8 @@ typedef NSInteger ExecuTorchIntegerValue
    NS_SWIFT_BRIDGED_TYPEDEF NS_SWIFT_NAME(IntegerValue);
 typedef double ExecuTorchDoubleValue
    NS_SWIFT_BRIDGED_TYPEDEF NS_SWIFT_NAME(DoubleValue);
+    typedef float ExecuTorchFloatValue


nit: fix indentation?

shoumikhin · 2025-05-13T14:39:48Z

extension/apple/ExecuTorch/Exported/ExecuTorchValue.mm

@@ -88,6 +88,12 @@ - (ExecuTorchDoubleValue)doubleValue {
  return [(ExecuTorchScalarValue)_value doubleValue];
 }

+- (ExecuTorchFloatValue)floatValue {
+  ET_CHECK(self.isFloat);
+  // EValue does not have a separate tag for float.


This comment belongs to isFloat implementation?

Summary: I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

facebook-github-bot · 2025-05-13T14:43:45Z

This pull request was exported from Phabricator. Differential Revision: D74603334

Summary: Pull Request resolved: pytorch#10823 I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

f-meloni · 2025-05-13T15:52:43Z

@pytorchbot label "release notes: api"

Summary: I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

facebook-github-bot · 2025-05-13T15:58:12Z

This pull request was exported from Phabricator. Differential Revision: D74603334

Summary: Pull Request resolved: pytorch#10823 I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

Summary: I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

facebook-github-bot · 2025-05-13T15:59:06Z

This pull request was exported from Phabricator. Differential Revision: D74603334

f-meloni requested a review from shoumikhin as a code owner May 12, 2025 20:38

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2025

facebook-github-bot added the fb-exported label May 12, 2025

pytorch-bot bot added the module: user experience Issues related to reducing friction for users label May 12, 2025

f-meloni force-pushed the export-D74603334 branch from f31e8ed to 8b5d2b0 Compare May 12, 2025 20:54

shoumikhin reviewed May 12, 2025

View reviewed changes

f-meloni force-pushed the export-D74603334 branch from 8b5d2b0 to 6bcb611 Compare May 13, 2025 12:57

f-meloni force-pushed the export-D74603334 branch from 6bcb611 to 0a46aaa Compare May 13, 2025 12:58

f-meloni force-pushed the export-D74603334 branch 2 times, most recently from 1e80fec to 3d0b1af Compare May 13, 2025 14:23

shoumikhin approved these changes May 13, 2025

View reviewed changes

shoumikhin reviewed May 13, 2025

View reviewed changes

f-meloni force-pushed the export-D74603334 branch from 3d0b1af to 2405f6f Compare May 13, 2025 14:40

f-meloni force-pushed the export-D74603334 branch from 2405f6f to e33b392 Compare May 13, 2025 14:43

pytorch-bot bot added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label May 13, 2025

f-meloni force-pushed the export-D74603334 branch from e33b392 to 2adfa17 Compare May 13, 2025 15:54

f-meloni force-pushed the export-D74603334 branch from 2adfa17 to 1f167ca Compare May 13, 2025 15:58

Add floatValue to ExecuTorch value (pytorch#10823)

4120a69

Summary: I think we can have an utility to return floats back. I would not create a new tag, but just use the double value and return it as float if the user needs float Reviewed By: shoumikhin Differential Revision: D74603334

f-meloni force-pushed the export-D74603334 branch from 1f167ca to 4120a69 Compare May 13, 2025 15:58

facebook-github-bot merged commit 3ffe697 into pytorch:main May 13, 2025
87 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add floatValue to ExecuTorch value #10823

Add floatValue to ExecuTorch value #10823

f-meloni commented May 12, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented May 12, 2025 •

edited

Loading

facebook-github-bot commented May 12, 2025

f-meloni commented May 12, 2025

facebook-github-bot commented May 12, 2025

shoumikhin May 12, 2025

shoumikhin May 12, 2025

shoumikhin May 12, 2025

shoumikhin May 12, 2025

facebook-github-bot commented May 13, 2025

facebook-github-bot commented May 13, 2025

facebook-github-bot commented May 13, 2025

shoumikhin May 13, 2025 •

edited

Loading

shoumikhin May 13, 2025

facebook-github-bot commented May 13, 2025

f-meloni commented May 13, 2025

facebook-github-bot commented May 13, 2025

facebook-github-bot commented May 13, 2025

	typedef double ExecuTorchFloatValue
	typedef float ExecuTorchFloatValue

	* @return A BOOL indicating whether the value is a double.
	* @return A BOOL indicating whether the value is a float.

Add floatValue to ExecuTorch value #10823

Add floatValue to ExecuTorch value #10823

Conversation

f-meloni commented May 12, 2025 • edited by pytorch-bot bot Loading

pytorch-bot bot commented May 12, 2025 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10823

❗ 1 Active SEVs

⏳ No Failures, 4 Pending

facebook-github-bot commented May 12, 2025

f-meloni commented May 12, 2025

facebook-github-bot commented May 12, 2025

shoumikhin May 12, 2025

Choose a reason for hiding this comment

shoumikhin May 12, 2025

Choose a reason for hiding this comment

shoumikhin May 12, 2025

Choose a reason for hiding this comment

shoumikhin May 12, 2025

Choose a reason for hiding this comment

facebook-github-bot commented May 13, 2025

facebook-github-bot commented May 13, 2025

facebook-github-bot commented May 13, 2025

shoumikhin May 13, 2025 • edited Loading

Choose a reason for hiding this comment

shoumikhin May 13, 2025

Choose a reason for hiding this comment

facebook-github-bot commented May 13, 2025

f-meloni commented May 13, 2025

facebook-github-bot commented May 13, 2025

facebook-github-bot commented May 13, 2025

f-meloni commented May 12, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented May 12, 2025 •

edited

Loading

shoumikhin May 13, 2025 •

edited

Loading