Exporting start_time in InstructionEvent to Inspector (#10295) #10344
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
ETDump profiled data does not include start_time information when Inspector analyzes Events. Although InstructionEvent's ProfileEvent member contains start_time and end_time information, they are used to only elpased_time which is exposed to Inspect. However, without the information, we are unable to visualize the time-series view of operator executions. This diff is to expose the start_time to Inspector so that it can access the start_time information.
#### A resulting visualization example with start_time
{F1977252760}
Differential Revision: D72740782
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10344
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7790e92 with merge base 7c150d4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72740782 |
|
@pytorchbot label "topic: not user facing" |
|
LGTM |
juyoung-meta
approved these changes
Apr 22, 2025
tarun292
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ETDump profiled data does not include start_time information when Inspector analyzes Events. Although InstructionEvent's ProfileEvent member contains start_time and end_time information, they are used to only elpased_time which is exposed to Inspect. However, without the information, we are unable to visualize the time-series view of operator executions. This diff is to expose the start_time to Inspector so that it can access the start_time information.
A resulting visualization example with start_time
{F1977252760}
Differential Revision: D72740782