[BE] Convert quantization internal methods private #2568
+14
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2568
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9b6df39 with merge base 460aaed ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jainapurva
added
topic: bc-breaking
vkuzo
approved these changes
Jul 18, 2025
andrewor14
approved these changes
Jul 18, 2025
| @@ -66,11 +66,11 @@ | |||
| AUTOQUANT_CACHE = {} | |||
There was a problem hiding this comment.
can you also make this one private?
| @@ -33,10 +32,8 @@ | |||
|
|
|||
| __all__ = [ | |||
| "compute_error", | |||
| "_apply_logging_hook", | |||
| "quantize_activation_per_token_absmax", | |||
| "quant_int8_dynamic_per_token_linear", | |||
There was a problem hiding this comment.
which other functions in this list can also be privatized? Looks like these 2 at least aren't used outside of torchao (and I don't think we intend them to be). Seems like there are a few more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of clean code, we're converting internal implementations private and removing old deprecated APIs.
torchao/quantization/autoquant.py
check_cache->_check_cacheupdate_cache->_update_cachetorchao/quantization/utils.py
guard_dtype_size->_guard_dtype_sizequant_int8_per_token_matmul->_quant_int8_per_token_matmul