Add int8 LUT CPU ops #2026
Merged
Add int8 LUT CPU ops #2026
+512
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2026
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 665dab3 with merge base df532f0 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
approved these changes
Apr 22, 2025
| @@ -126,7 +126,7 @@ void pack_weights( | |||
| bias); | |||
| } | |||
|
|
|||
| template <int weight_nbit, int nr, int kr, int sr> | |||
| template <int weight_nbit, int nr_, int kr_, int sr_> | |||
There was a problem hiding this comment.
Nit: suffix _ has different meaning too i.e. class private variables, what about capitalized?
Comment on lines
145
to
+146
| pack_weights_fn_type pack_weights{nullptr}; | ||
| pack_weights_with_lut_fn_type pack_weights_with_lut{nullptr}; |
There was a problem hiding this comment.
should we have a different uKernel config for LUT? or even worse a union :)
Suggested change
| pack_weights_fn_type pack_weights{nullptr}; | |
| pack_weights_with_lut_fn_type pack_weights_with_lut{nullptr}; | |
| union pack_weights_fn_t { | |
| pack_weights_fn_type tiled{nullptr}; | |
| pack_weights_with_lut_fn_type tiled_with_lut{nullptr}; | |
| } |
There was a problem hiding this comment.
I prefer separate ones for now
| int weight_nbit, | ||
| bool has_weight_zeros, | ||
| bool has_bias, | ||
| packed_weights_size_fn_type packed_weights_with_lut_size, |
| weight_nbit | ||
| ); | ||
| constexpr bool has_lut = true; | ||
| int preferred_alignment = 16; |
There was a problem hiding this comment.
nit: push this down closer to the kernel?
metascroy
added
the
topic: not user facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds op support for 1-4 bit LUT kernels (int8 multiple of FP32 scale).