Upgrade cuda from 12.4 -> 12.6 #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1962
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit c253dc0 with merge base 7fa9c69 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jainapurva
added a commit
that referenced
this pull request
Mar 26, 2025
ghstack-source-id: cb1cfff2745bacc99e73276fa2a487ee316bb71d ghstack-comment-id: 2754997519 Pull Request resolved: #1962
facebook-github-bot
added
the
CLA Signed
jainapurva
changed the title
jainapurva
added
topic: not user facing
drisspg
approved these changes
Mar 26, 2025
|
Seems like CI is unhappy though |
Yes, it's not able to install the 12.6 driver. @atalman is looking into it. |
|
@huydhn Can you please take a look at this. |
|
Let me take a look at the CI error |
huydhn
reviewed
Apr 15, 2025
huydhn
reviewed
Apr 15, 2025
huydhn
reviewed
Apr 15, 2025
huydhn
reviewed
Apr 15, 2025
huydhn
reviewed
Apr 15, 2025
jerryzh168
reviewed
Apr 15, 2025
malfet
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Apr 16, 2025
This is reported by @jainapurva from TorchAO https://github.com/pytorch/ao/actions/runs/14461343872/job/40554407661 trying to upgrade CUDA from 12.4 to 12.6 pytorch/ao#1962. It turns out that the NVIDIA driver that we are currently using `550.54.15` is too old. I grab the latest production driver from NVIDIA which should satisfy not only CUDA 12.6 but 12.8 too: * https://docs.nvidia.com/cuda/archive/12.8.0/cuda-toolkit-release-notes/index.html This should help fix the issue on AO, also need to update this driver in a couple of other places too. ### Testing * Manual. I install the driver manually and can start the container fine without any issue `docker run --gpus all -it pytorch/almalinux-builder:cuda12.6 /bin/bash` * https://github.com/pytorch/test-infra/actions/runs/14481525016 * ~~Also test this out on AO https://github.com/pytorch/ao/actions/runs/14481627872/job/40619564626~~ I think this needs to be landed first as AO jobs still point to `test-infra@main`
|
I think I have had almost everything working with 2 remaining issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the cuda version from 12.4 -> 12.6, as 12.4 is not supported anymore.
All pytorch nightly tests will be using cu12.6 going forward. Only H100 tests are still using cu124 version with pytorch nightly, as H100 driver upgrade could not be done. Once the issue is fixed for H100 driver upgrade, we’ll be able to update our CI tests accordingly