Gate regex lookahead in cmake behind compile flag #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jackzhxng
force-pushed
the
jz/size-regression
branch
from
42f2f1e to
7e8c212
Compare
Summary: Make the pcre2 fallback optional to offer library size savings ``` cmake -DSUPPORT_REGEX_LOOKAHEAD=ON -DTOKENIZERS_BUILD_TOOLS=ON . -Bbuild && cmake --build build -j9 stat -f "%z %N" build/libtokenizers.a 6394880 build/libtokenizers.a cmake -DTOKENIZERS_BUILD_TOOLS=ON . -Bbuild && cmake --build build -j9 stat -f "%z %N" build/libtokenizers.a 6311960 build/libtokenizers.a # Difference of 6394880 - 6311960 = 82920 bytes ``` BSB results on IOS `messenger-distribution`: ``` Changes for variation [arm64 + 3x assets]: Compressed : -80.4 KiB (-0.12%) => 64.92 MiB Uncompressed: -235.2 KiB (-0.17%) => 138.98 MiB ``` Compared to app size regression reported from 222011767: ``` uncompressed_delta_size_arm64@3x: change of 233058 (0.16%) exceeds threshold of 40960 ``` Differential Revision: D73530475 Pulled By: jackzhxng
facebook-github-bot
force-pushed
the
jz/size-regression
branch
from
7e8c212 to
964c934
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73530475 |
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the pcre2 fallback optional to offer library size savings