Use dependency injection for runner #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73165546 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 21, 2025
Summary: X-link: pytorch/executorch#10326 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
facebook-github-bot
force-pushed
the
export-D73165546
branch
from
2ae1d60 to
b88bbc2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73165546 |
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Apr 21, 2025
Summary: X-link: pytorch-labs/tokenizers#53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
larryliu0820
added a commit
that referenced
this pull request
Apr 22, 2025
Summary: X-link: pytorch/executorch#10326 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
larryliu0820
force-pushed
the
export-D73165546
branch
from
b88bbc2 to
c7686a9
Compare
larryliu0820
added a commit
to pytorch/executorch
that referenced
this pull request
Apr 22, 2025
Summary: X-link: pytorch-labs/tokenizers#53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
Summary: X-link: pytorch/executorch#10326 Pull Request resolved: #53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
larryliu0820
added a commit
to pytorch/executorch
that referenced
this pull request
Apr 22, 2025
Summary: Pull Request resolved: #10326 X-link: pytorch-labs/tokenizers#53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
|
This pull request was exported from Phabricator. Differential Revision: D73165546 |
larryliu0820
force-pushed
the
export-D73165546
branch
from
c7686a9 to
8724664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pass in runner components, move most of the instantiation logic from
load()to a new static APIcreate().This adds testability to runner components.
Differential Revision: D73165546