: slice: Slice::view #113
Open
: slice: Slice::view #113
+159
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75761780 |
shayne-fletcher
force-pushed
the
export-D75761780
branch
from
3f318f3 to
779d62f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75761780 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jun 1, 2025
Summary: implements `Slice::view(&[usize]) -> Result<Slice>` with validation logic mirroring `torch.Tensor.view`. requires element count match and verifies row-major view layout is reachable in the base slice. conservative, safe reshape for canonical slices. Differential Revision: D75761780
shayne-fletcher
force-pushed
the
export-D75761780
branch
from
779d62f to
dfbf252
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75761780 |
shayne-fletcher
force-pushed
the
export-D75761780
branch
from
dfbf252 to
bbba782
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75761780 |
Summary: implement `Slice::view(&[usize]) -> Result<Slice>` with validation logic mirroring `torch.Tensor.view`. requires element count match and that the base slice has offset 0. verifies that row-major view layout is reachable in the base slice. conservative, safe reshape for canonical slices. changed `reshape::view_limit` to `reshape::reshape_with_limit`. this clarifies that it constructs a new shape structurally rather than reinterpreting an existing one, avoiding confusion with the stricter, validating `view()` operation. Differential Revision: D75761780
shayne-fletcher
force-pushed
the
export-D75761780
branch
from
bbba782 to
52ca686
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75761780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D75761780