: add new module 'view' (#109) #112
Open
+518
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75747680 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jun 1, 2025
Summary: Differential Revision: D75747680
shayne-fletcher
force-pushed
the
export-D75747680
branch
from
5629779 to
f73ae99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75747680 |
Summary: this diff introduces `LayoutMap` and `LayoutMapInverse` traits and implements them for `Slice`, extracting core layout logic (`offset_of`, `coord_of`) into dedicated abstractions. motivation: this sets up `view()` — and other shape-preserving transforms — to share layout logic without duplicating or entangling with `Slice`. by extracting `offset_of` and `coord_of` into `LayoutMap` traits, we make the layout logic reusable. this lets future features like `view()` reuse indexing without tying everything to `Slice`. - defines `LayoutMap` trait for `affine` memory layouts, providing `offset_of()` - defines `LayoutMapInverse` for invertible layouts, providing `coord_of()` - implements both traits for `Slice` using existing logic - rewrites `location()` and `coordinates()` to delegate to the traits - isolates layout logic and enables future generalization (e.g., `view`s, `reshape`s) - no behavior change; covered by existing test suite this extracts the core logic for layout/indexing into dedicated traits, simplifying `Slice` and preparing for shape-preserving transformations Differential Revision: D75746358
Summary: introduces `View<'a>`: a lazy, composable layout reinterpretation over a base `LayoutMap`, modeled after `torch.Tensor.view`. enables shape reparametrization (e.g. `[6] → [2, 3]`) without copying, deferring validation until finalization (`into_slice`, not yet implemented). adds `LayoutTransformExt` for ergonomic `.view(&[...])?` construction on any `LayoutMap`. implements `LayoutMap` for `View` to support forward address computation. note: `View` is not yet usable in practice — `validate_layout` and `into_slice` are missing, and there are no tests. compatibility checks are limited to element count and reachability of the view origin. Differential Revision: D75747680
shayne-fletcher
force-pushed
the
export-D75747680
branch
from
f73ae99 to
23dbb98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75747680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: #109
Differential Revision: D75747680