Skip to content

start fixing issue 14168 with TarFile #14172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
+334 −2
Open

start fixing issue 14168 with TarFile #14172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4391d31
start fixing issue 14168 with TarFile
alexeev-prog May 27, 2025
1770440
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 27, 2025
6b387d5
fix errors with `__init__`, start add @override for other methods of …
alexeev-prog May 27, 2025
b652aac
Merge branch 'issue-14168-fix' of github.com:alexeev-prog/typeshed in…
alexeev-prog May 27, 2025
f3f21dd
fix None/None case for other methods
alexeev-prog May 27, 2025
f0a4410
add overload to `__init__`
alexeev-prog May 27, 2025
6f4f644
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 27, 2025
1e03be9
fix overrided init methods
alexeev-prog May 27, 2025
082f762
fix overrided init methods #2
alexeev-prog May 27, 2025
0ec9a85
fix syntax error in __init__ methods
alexeev-prog May 27, 2025
a7a5e8d
fix errors in overrided init methods
alexeev-prog May 27, 2025
7eae058
fix errors in overrided init methods for python<3.13
alexeev-prog May 27, 2025
69938e9
work with overrired `open` methods in TarFile
alexeev-prog May 27, 2025
5e4f00b
fix stubtest errors for TarFile overrided methods
alexeev-prog May 27, 2025
5f3c820
add info about TarFile in allowlists
alexeev-prog May 27, 2025
d47a5da
add info about TarFile in allowlists
alexeev-prog May 27, 2025
51b46c9
fix info about TarFile in allowlists
alexeev-prog May 27, 2025
5fded29
Merge branch 'main' into issue-14168-fix
alexeev-prog May 27, 2025
5a117a4
Merge branch 'main' into issue-14168-fix
alexeev-prog May 28, 2025
b0a3c2e
Merge branch 'main' into issue-14168-fix
alexeev-prog Jun 2, 2025
3c86c48
Merge branch 'main' into issue-14168-fix
alexeev-prog Jun 4, 2025
dbd91b9
Merge branch 'main' into issue-14168-fix
alexeev-prog Jun 6, 2025
a10400f
Merge branch 'main' into issue-14168-fix
alexeev-prog Jun 9, 2025
df4bc3a
Merge branch 'main' into issue-14168-fix
alexeev-prog Jun 11, 2025
0076976
Merge branch 'main' into issue-14168-fix
alexeev-prog Jun 12, 2025
44b2e2f
Merge branch 'main' into issue-14168-fix
alexeev-prog Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stdlib/@tests/stubtest_allowlists/common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,3 +556,5 @@ xml.etree.cElementTree.XMLParser.__init__ # Defined in C so has general signatu
# These would ideally be special-cased by type checkers; see https://github.com/python/mypy/issues/2220
xml.etree.ElementTree.Element.__iter__
xml.etree.cElementTree.Element.__iter__

tarfile.open # Overridden by TarFile.open
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems suspect. What's the reason the new signature doesn't pass stubtest when the old signature did?

Loading