Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
May 12, 2025
Comment on lines
+421
to
+425
| POSITIONAL_ONLY: ClassVar[Literal[0]] | ||
| POSITIONAL_OR_KEYWORD: ClassVar[Literal[1]] | ||
| VAR_POSITIONAL: ClassVar[Literal[2]] | ||
| KEYWORD_ONLY: ClassVar[Literal[3]] | ||
| VAR_KEYWORD: ClassVar[Literal[4]] |
Collaborator
There was a problem hiding this comment.
That's not true, at least not for Python 3.12:
Python 3.12.3 (main, Feb 4 2025, 14:48:35) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import inspect
>>> inspect.Parameter.POSITIONAL_ONLY
<_ParameterKind.POSITIONAL_ONLY: 0>
>>> type(inspect.Parameter.POSITIONAL_ONLY)
<enum '_ParameterKind'>
Contributor
Author
There was a problem hiding this comment.
thanks you, this was an attempt to solve this error. apparently I was too hasty in getting the PR ready for review
Member
There was a problem hiding this comment.
I suspect it's because you made enum import inspect and that disturbed some import cycle. As you can see from the mypy-primer report, this change is going to cause a lot of issues.
Contributor
Author
There was a problem hiding this comment.
you're right because these errors appeared when i added import
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.