Split tool.stubtest.platforms metadata key
#13746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when running it on Linux without the `--specified-platforms-only` flag, it printed spurious warnings and ran stubtest anyway for distributions that didn't include `linux` as a supported platform. Rearrange things: * The `--specified-platforms-only` now works consistently on all platforms. Previously, it was ignored on Linux. * Instead, in CI the flag is added only for non-Linux platforms. * The note about stubtest not running for a certain platform in CI is now printed only after stubtest tested a distribution successfully to avoid breaking the output. Closes: python#13641
The new `supported_platforms` and `ci_platforms` keys allow better control over the platforms stubtest is run on locally and in CI. Rename `stubtest_third_party.py` command line option `--supported-platforms-only` to `--ci-platforms-only` to match this change.
Avasam
reviewed
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
supported_platformsandci_platformskeysallow better control over the platforms stubtest is run on
locally and in CI.
Rename
stubtest_third_party.pycommand line option--supported-platforms-onlyto--ci-platforms-onlyto matchthis change.
This fixes spurious warnings when running locally using Linux.
Cf. #13643