Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 696: Mark as Final #3941

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 3, 2024

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3781, cc @Gobot1234.

This is documented in the typing spec at https://typing.readthedocs.io/en/latest/spec/generics.html#type-parameter-defaults.

Is it documented at https://docs.python.org/3.13/? Should it be?

@hugovk hugovk mentioned this pull request Sep 3, 2024
5 tasks
@JelleZijlstra
Copy link
Member

It's documented, though I'm not sure there's a single place to link to. It's mentioned for example at https://docs.python.org/3.13/reference/compound_stmts.html#type-parameter-lists and https://docs.python.org/3.13/library/typing.html#typing.TypeVar.__default__.

@hugovk
Copy link
Member Author

hugovk commented Sep 3, 2024

Hmm, well here's a link to the first one.

@hugovk hugovk marked this pull request as ready for review September 3, 2024 17:17
@JelleZijlstra JelleZijlstra merged commit e5fecd4 into python:main Sep 3, 2024
6 checks passed
@hugovk hugovk deleted the pep696-mark-as-final branch September 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants