-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 647: Mark as Final #3577
PEP 647: Mark as Final #3577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah the implementation is done. Source: me and Guido implemented it https://docs.python.org/3/whatsnew/3.10.html#pep-647-user-defined-type-guards.
I'd prefer to wait until the typing spec is merged, then point to the spec as the canonical implementation. (This goes for all typing PEPs.) |
That sounds like a good idea, about half of the 45 "may not be implemented yet" PEPs are typing. :) Until then, shall I close this and #3575, or convert them to drafts? |
Did you mean canonical documentation? |
Oops, yes.
Let's just wait. We should be able to merge the spec once Guido OKs it :) |
I think I accidentally deleted this branch in December, which closed the PR. Anyway, the typing spec has been published so we can link there now. PR updated and re-opened! |
PEP 123: Mark Final
)Status
changed toFinal
(andPython-Version
is correct)canonical-doc
directive (orcanonical-pypa-spec
, for packaging PEPs)Helps #2872 and #3579.
Link to https://docs.python.org/3/library/typing.html#typing.TypeGuard as the canonical docs, and remove some redundant headers.
cc @Fidget-Spinner
📚 Documentation preview 📚: https://pep-previews--3577.org.readthedocs.build/pep-0647/