-
-
Notifications
You must be signed in to change notification settings - Fork 3k
[mypyc] feat: improve LoadLiteral annotation determinism #20012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BobTheBuidler
wants to merge
13
commits into
python:master
Choose a base branch
from
BobTheBuidler:anns-determinism
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c2bf11e
[mypyc] feat: improve LoadLiteral annotation determinism
BobTheBuidler d750ec1
Update emit.py
BobTheBuidler 486f9f0
new sort key
BobTheBuidler c30a727
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d174f4e
use new safe key
BobTheBuidler 28c0399
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] be0de78
Update emit.py
BobTheBuidler d33d2d9
Update emit.py
BobTheBuidler 650d99d
Update emit.py
BobTheBuidler da22785
Update emit.py
BobTheBuidler 96aa63e
refactor
BobTheBuidler 58e4b67
Update emit.py
BobTheBuidler ca1e97f
Merge branch 'master' into anns-determinism
BobTheBuidler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, isn't this still random?
repr(obj)
might not be a deterministic ordering? Or is it deterministic because maybe frozenset is the same repr based on the same input (I would check but... lazy).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's deterministic so long as the objects contained within the tuple are supported mypyc literal types, and this should have already been validated by this point in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, you're correct in one case: if the frozenset contains another frozenset
This can be mitigated by replacing repr with pformat (to ensure the frozenset goes thru the same ordering process)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented this recursive pformatting, let me know if this works for you