Ensure reconstructed Enums are idompotent #19863
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, mypy would infer that
Foo(Foo.x)
is of typeFoo
(whereFoo
is anEnum
). This is problematic as it means Enums can not be reconstructed for runtime saftey (see quote below for more detail).Hence, this PR extends the enum plugin and refines the return type of
Enum.__new__
, ensuring reconstructed Enums are idempotent.Fixes #19669
(Taken from #19669,) below gives an example as of why we care about reconstructed Enums: