support Callable / callable Protocols in suggest decorator unwarpping #19072
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sterliakov
reviewed
May 10, 2025
| @@ -659,7 +671,7 @@ def extract_from_decorator(self, node: Decorator) -> FuncDef | None: | |||
| for ct in typ.items: | |||
| if not ( | |||
| len(ct.arg_types) == 1 | |||
| and isinstance(ct.arg_types[0], TypeVarType) | |||
| and _arg_accepts_function(get_proper_type(ct.arg_types[0])) | |||
| and ct.arg_types[0] == ct.ret_type | |||
There was a problem hiding this comment.
Can this become is_same_type to allow aliases?
There was a problem hiding this comment.
I assume you mean the == line?
probably! but that'd be a separate issue / patch I would imagine
There was a problem hiding this comment.
Yes, sorry, misclicked - I meant the == line of course.
sterliakov
reviewed
May 12, 2025
| @@ -659,7 +671,7 @@ def extract_from_decorator(self, node: Decorator) -> FuncDef | None: | |||
| for ct in typ.items: | |||
| if not ( | |||
| len(ct.arg_types) == 1 | |||
| and isinstance(ct.arg_types[0], TypeVarType) | |||
| and _arg_accepts_function(get_proper_type(ct.arg_types[0])) | |||
| and ct.arg_types[0] == ct.ret_type | |||
There was a problem hiding this comment.
Yes, sorry, misclicked - I meant the == line of course.
Co-authored-by: Stanislav Terliakov <[email protected]>
sterliakov
approved these changes
May 12, 2025
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18940
while I feel like just accepting any identity function would be good enough I expanded the check to explicitly allow Callables and Protocol callables