Fix crash on decorated getter in settable property #18787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This does resolve the crash. Thanks for the quick fix @ilevkivskyi! |
JukkaL
approved these changes
Mar 11, 2025
davidhalter
reviewed
Apr 20, 2025
| @@ -8514,12 +8514,23 @@ class C(B): | |||
| @deco_untyped | |||
| def baz(self, x: int) -> None: ... | |||
|
|
|||
| @property | |||
| def tricky(self) -> int: ... | |||
| @baz.setter | |||
There was a problem hiding this comment.
It feels like this should probably be @tricky.setter. Unless this is intentional, but it definitely looks like a copy/paste issue.
There was a problem hiding this comment.
Looks that way. Thanks for letting us know! Opened #18946 to fix it.
ilevkivskyi
pushed a commit
that referenced
this pull request
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #18774
Fix for crash is trivial, properly handle getter the same way as setter. Note I also consistently handle callable instances.
cc @cdce8p could you please check this branch?