Skip to content

Skip checking canonical links if nothing was built #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025
Merged

Skip checking canonical links if nothing was built #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions build_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ def build_docs(args: argparse.Namespace) -> bool:
switchers_content = render_switchers(versions, languages)

build_succeeded = set()
build_failed = set()
any_build_failed = False
cpython_repo = Repository(
"https://github.com/python/cpython.git",
args.build_root / _checkout_name(args.select_output),
Expand Down Expand Up @@ -1130,7 +1130,7 @@ def build_docs(args: argparse.Namespace) -> bool:
if built_successfully:
build_succeeded.add((version.name, language.tag))
elif built_successfully is not None:
build_failed.add((version.name, language.tag))
any_build_failed = True

logging.root.handlers[0].setFormatter(
logging.Formatter("%(asctime)s %(levelname)s: %(message)s")
Expand All @@ -1153,11 +1153,13 @@ def build_docs(args: argparse.Namespace) -> bool:
args.skip_cache_invalidation,
http,
)
proofread_canonicals(args.www_root, args.skip_cache_invalidation, http)
if build_succeeded:
# Only check canonicals if at least one version was built.
proofread_canonicals(args.www_root, args.skip_cache_invalidation, http)

logging.info("Full build done (%s).", format_seconds(perf_counter() - start_time))

return len(build_failed) == 0
return any_build_failed


def parse_versions_from_devguide(http: urllib3.PoolManager) -> Versions:
Expand Down