Skip to content

Document type-refactor #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Document type-refactor #1588

wants to merge 4 commits into from
+2 −0

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jun 24, 2025 •
edited by hugovk
Loading

ezio-melotti
ezio-melotti reviewed Jun 24, 2025
View reviewed changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be worth expanding a bit more on what is considered "internal code refactoring". E.g. are any behavior changes admitted, if not user-facing? Are refactoring of user-facing functions, without changes in behavior included?

@ZeroIntensity ZeroIntensity mentioned this pull request Jun 24, 2025
Closed
@ZeroIntensity
Copy link
Member

I made an issue for this, I hadn't seen this PR. Feel free to link to it in the title.

@StanFromIreland StanFromIreland linked an issue Jun 24, 2025 that may be closed by this pull request
Feature: Document the new type-refactor label #1589
Open
@StanFromIreland
Copy link
Member Author

No worries, we don't usually link issues in titles here anyway.

ZeroIntensity
ZeroIntensity reviewed Jun 28, 2025
View reviewed changes
@StanFromIreland @ZeroIntensity
Update triage/labels.rst
f028bdc 
Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity
ZeroIntensity approved these changes Jun 28, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm by no means a devguide expert. @hugovk, would you like to review?

@hugovk
Copy link
Member

hugovk commented Jun 30, 2025

I think it might be worth expanding a bit more on what is considered "internal code refactoring". E.g. are any behavior changes admitted, if not user-facing? Are refactoring of user-facing functions, without changes in behavior included?

@ezio-melotti Have your questions been addressed?

Not a big deal, but we don't really need a new issue here (#1589) when we already have python/core-workflow#563, plus it can be good to leave these easier issues for new contributors, at least for a little while. Thanks!

@ZeroIntensity
Copy link
Member

Yeah, sorry about that. I'm used to CPython's workflow where we have an issue for every little thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Document the new type-refactor label Add type-refactor label
4 participants
@StanFromIreland @ZeroIntensity @hugovk @ezio-melotti