Repository navigation
gh-160179: Leave bytearray empty when __init__() fails midway - #160180
Merged
Merged
Conversation
The list/tuple fast path and the buffer path resized the object before filling it and did not undo the resize on error, leaving stale bytes.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
October 22, 2026 04:22
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @gpshead, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-160202 is a backport of this pull request to the 3.15 branch. |
|
GH-160204 is a backport of this pull request to the 3.14 branch. |
gpshead
added a commit
that referenced
this pull request
Oct 22, 2026
…H-160180) (#160202) gh-160179: Leave bytearray empty when __init__() fails midway (GH-160180) The list/tuple fast path and the buffer path resized the object before filling it and did not undo the resize on error, leaving stale bytes. (cherry picked from commit 5a63d35) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
gpshead
added a commit
that referenced
this pull request
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset the bytearray to empty on the two
__init__()error exits that return after resizing but before every byte is written: an out-of-range int in the list/tuple fast path, and aPyBuffer_ToContiguous()failure in the buffer path. This matches what the neighbouring non-int exit already does. The resize to 0 cannot fail here since_canresize()was checked on entry and no Python code runs in between.Fixes #160179
ANT-2026-JQ5RCTS2