Conversation
Member
|
I think #157687 will fix this as well, but I suppose we could use this for 3.15 and below. cc @kumaraditya303 |
Member
|
This would introduce contention in the FT build I think. We need some benchmarks to know if there are some real performance impacts. I believe we already have one open issue about a similar problem where we still did not have make the change just because of FT performance impacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiter(callable, sentinel)compared the sentinel through a borrowed reference. A reentrant__eq__can exhaust the iterator and free that object while the comparison is still using it.Hold a strong reference for the duration of
PyObject_RichCompareBool.Fixes #158033.