Skip to content

ci: move read permissions from workflow to job level #156411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maksimtech wants to merge 2 commits into from
+23 −2
Closed

ci: move read permissions from workflow to job level #156411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8241bd
ci: move contents:read permission from workflow to job level
maksimtech Aug 26, 2026
efe179f
Merge branch 'main' into fix/permissions-job-level
maksimtech Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ on:
- 'main'
- '3.*'

permissions:
contents: read
permissions: {}

concurrency:
# https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#concurrency
Expand Down Expand Up @@ -51,6 +50,8 @@ jobs:

check-autoconf-regen:
name: 'Check if Autoconf files are up to date'
permissions:
contents: read
# Don't use ubuntu-latest but a specific version to make the job
# reproducible: to get the same tools versions (autoconf, aclocal, ...)
runs-on: ubuntu-26.04
Expand Down Expand Up @@ -94,6 +95,8 @@ jobs:

check-generated-files:
name: 'Check if generated files are up to date'
permissions:
contents: read
# Don't use ubuntu-latest but a specific version to make the job
# reproducible: to get the same tools versions (autoconf, aclocal, ...)
runs-on: ubuntu-26.04
Expand Down Expand Up @@ -151,6 +154,8 @@ jobs:

build-windows:
name: >-
permissions:
contents: read
Windows
${{ fromJSON(matrix.free-threading) && '(free-threading)' || '' }}
needs: build-context
Expand Down Expand Up @@ -183,6 +188,8 @@ jobs:

build-macos:
name: >-
permissions:
contents: read
macOS
${{ fromJSON(matrix.free-threading) && '(free-threading)' || '' }}
needs: build-context
Expand All @@ -208,6 +215,8 @@ jobs:

build-ubuntu:
name: >-
permissions:
contents: read
Ubuntu
${{ fromJSON(matrix.free-threading) && '(free-threading)' || '' }}
${{ fromJSON(matrix.bolt) && '(bolt)' || '' }}
Expand Down Expand Up @@ -253,6 +262,8 @@ jobs:

build-ubuntu-ssltests:
name: 'Ubuntu SSL tests'
permissions:
contents: read
runs-on: ${{ matrix.os }}
timeout-minutes: 60
needs: build-context
Expand Down Expand Up @@ -326,6 +337,8 @@ jobs:

build-android:
name: Android (${{ matrix.arch }})
permissions:
contents: read
needs: build-context
if: needs.build-context.outputs.run-android == 'true'
timeout-minutes: 60
Expand All @@ -348,6 +361,8 @@ jobs:

build-ios:
name: iOS
permissions:
contents: read
needs: build-context
if: needs.build-context.outputs.run-ios == 'true'
timeout-minutes: 60
Expand All @@ -374,6 +389,8 @@ jobs:

test-hypothesis:
name: "Hypothesis tests on Ubuntu"
permissions:
contents: read
runs-on: ubuntu-26.04
timeout-minutes: 60
needs: build-context
Expand Down Expand Up @@ -478,6 +495,8 @@ jobs:

build-asan:
name: 'Address sanitizer'
permissions:
contents: read
runs-on: ${{ matrix.os }}
timeout-minutes: 60
needs: build-context
Expand Down Expand Up @@ -549,6 +568,8 @@ jobs:

cross-build-linux:
name: Cross build Linux
permissions:
contents: read
runs-on: ubuntu-26.04
timeout-minutes: 60
needs: build-context
Expand Down
Loading