Skip to content

Capitalize first word in unittest.mock.{assert_any_call,assert_has_calls} docs#151951

Merged
StanFromIreland merged 1 commit into
python:mainfrom
hy144328:docs/unittest-mock-assert-capital
Jun 24, 2026
Merged

Capitalize first word in unittest.mock.{assert_any_call,assert_has_calls} docs#151951
StanFromIreland merged 1 commit into
python:mainfrom
hy144328:docs/unittest-mock-assert-capital

Conversation

@hy144328

@hy144328 hy144328 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Start sentences in unittest.mock with a capital letter

Change two occurrences of 'assert' to uppercase.

@python-cla-bot

python-cla-bot Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Jun 22, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 22, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33284791 | 📁 Comparing acc04b8 against main (b1c4bda)

  🔍 Preview build  

10 files changed · ± 10 modified

± Modified

@hy144328

hy144328 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

This PR only fixes typos.
Thus, IMHO, the PR title does not require an issue number.

StanFromIreland
StanFromIreland approved these changes Jun 23, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland StanFromIreland changed the title docs(unittest.mock): Start sentence on uppercase. Capitalize first word in unittest.mock.{assert_any_call,assert_has_calls} docs Jun 23, 2026
@StanFromIreland

StanFromIreland commented Jun 23, 2026

Copy link
Copy Markdown
Member

Can you fix all the docstrings too, please:

cpython/Lib/unittest/mock.py

Line 939 in d1505b5

"""assert that the mock was never called.

@hy144328 hy144328 force-pushed the docs/unittest-mock-assert-capital branch from 9a36fbf to 883582f Compare June 23, 2026 22:36
@hy144328 hy144328 requested a review from cjw296 as a code owner June 23, 2026 22:36
@hy144328

hy144328 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Can you fix all the docstrings too, please:

cpython/Lib/unittest/mock.py

Line 939 in d1505b5

"""assert that the mock was never called.

@StanFromIreland Thank you for the input. I have now scanned the whole repo (not just Docs/) for relevant docstrings: git grep -Pz '"""\s*assert'.
I would appreciate another review.
Thanks!

@hy144328 hy144328 force-pushed the docs/unittest-mock-assert-capital branch from 883582f to 598db19 Compare June 23, 2026 23:21
@hy144328 hy144328 force-pushed the docs/unittest-mock-assert-capital branch from 598db19 to acc04b8 Compare June 24, 2026 07:52
@StanFromIreland StanFromIreland merged commit a46db4f into python:main Jun 24, 2026
93 of 95 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 24, 2026
@StanFromIreland

StanFromIreland commented Jun 24, 2026

Copy link
Copy Markdown
Member

Merged, thanks!

@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 24, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 24, 2026

Copy link
Copy Markdown

Thanks @hy144328 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 24, 2026

Copy link
Copy Markdown

Thanks @hy144328 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 24, 2026

Copy link
Copy Markdown

Thanks @hy144328 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 24, 2026

Copy link
Copy Markdown

Sorry, @hy144328 and @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a46db4f8ba4aa84e0fc5b6986c2388cae2e873ae 3.13

@StanFromIreland StanFromIreland removed the needs backport to 3.13 bugs and security fixes label Jun 24, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 24, 2026

Copy link
Copy Markdown

Sorry, @hy144328 and @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a46db4f8ba4aa84e0fc5b6986c2388cae2e873ae 3.14

@bedevere-app

bedevere-app Bot commented Jun 24, 2026

Copy link
Copy Markdown

GH-152059 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 24, 2026
@StanFromIreland StanFromIreland removed the needs backport to 3.14 bugs and security fixes label Jun 24, 2026
@StanFromIreland

StanFromIreland commented Jun 24, 2026

Copy link
Copy Markdown
Member

I don't think it's worth the time backporting, so dropping the labels.

StanFromIreland pushed a commit that referenced this pull request Jun 24, 2026
@miss-islington @hy144328
[3.15] Capitalize first word in unittest.mock.assert_* docs and doc…
dcbcf09 
…strings (GH-151951) (#152059)

(cherry picked from commit a46db4f)

Co-authored-by: Hans Yu <github@shauny.anonaddy.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hy144328 @StanFromIreland