Skip to content

gh-141004: Document pyctype.h macros #141272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2025
Merged

gh-141004: Document pyctype.h macros #141272

merged 3 commits into from
Nov 10, 2025
+65 −12

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 8, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 8, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Nov 8, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 8, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Nov 8, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like a candidate for soft deprecation, so please bring this up at capi-workgroup/decisions#86. I'm a bit surprised that they were intentionally added to the public API in 2.7, but character functions don't seem like CPython's job to support.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Nov 8, 2025

I concur, soft deprecation makes sense.

ZeroIntensity
ZeroIntensity approved these changes Nov 8, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with these! I'm going to hold off on merging until Monday in case someone else has a strong opinion on these.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Nov 9, 2025

@malemburg maybe you would like to review?

@ZeroIntensity ZeroIntensity merged commit df19261 into python:main Nov 10, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 10, 2025
@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 10, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 10, 2025

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 10, 2025

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @miss-islington
pythongh-141004: Document pyctype.h macros (pythonGH-141272)
c34a5d9 
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2025

GH-141339 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @miss-islington
pythongh-141004: Document pyctype.h macros (pythonGH-141272)
e8390d8 
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2025

GH-141340 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 10, 2025
ZeroIntensity pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland
[3.13] gh-141004: Document pyctype.h macros (GH-141272) (GH-141339)
9cbbb2e 
gh-141004: Document `pyctype.h` macros (GH-141272)
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <[email protected]>
ZeroIntensity pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland
[3.14] gh-141004: Document pyctype.h macros (GH-141272) (GH-141340)
c09a659 
gh-141004: Document `pyctype.h` macros (GH-141272)
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <[email protected]>
@StanFromIreland StanFromIreland deleted the pyctype branch November 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @ZeroIntensity