gh-139741: Make dist-pdf docs archive build work for macOS
#140837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-aciek
reviewed
Oct 31, 2025
Contributor
m-aciek
left a comment
m-aciek
left a comment
There was a problem hiding this comment.
Confirming it works on MacOS 26.0.1, thank you, sharing one concern
``getconf _NPROCESSORS_ONLN`` is available in both Linux and macOS, but ``nproc`` is not. This change prevents the build from breaking again if macOS ever upgrades its `make` to version 4 or above.
m-aciek
approved these changes
Nov 1, 2025
hugovk
reviewed
Nov 2, 2025
hugovk
approved these changes
Nov 3, 2025
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Thanks, confirmed this is working* on macOS.
* I don't have latexmk installed, but the commands are being called as expected.
hugovk
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2025
…ythonGH-140837) (cherry picked from commit 9c39946) Co-authored-by: Naitree Zhu <[email protected]>
|
GH-141229 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2025
…ythonGH-140837) (cherry picked from commit 9c39946) Co-authored-by: Naitree Zhu <[email protected]>
|
GH-141230 is a backport of this pull request to the 3.13 branch. |
hugovk
pushed a commit
that referenced
this pull request
Nov 8, 2025
…H-140837) (#141230) Co-authored-by: Naitree Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building docs archive in pdf format on macOS is currently unsuccessful. This PR fixes it.
Changes:
--output-syncon macOS, as macOS'smakedoes not yet support the output sync feature.nprocby default; usegetconf _NPROCESSORS_ONLNinstead.Thanks @m-aciek for providing the initial solution and PR suggestion.
📚 Documentation preview 📚: https://cpython-previews--140837.org.readthedocs.build/