Skip to content

(3.13) Fixes: (workflow) syntax problem and specified explicit Python…#139300

Closed
ghost wants to merge 1 commit into
3.13from
unknown repository
Closed

(3.13) Fixes: (workflow) syntax problem and specified explicit Python…#139300
ghost wants to merge 1 commit into
3.13from
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 24, 2025

Copy link
Copy Markdown

… version number 3.13

This PR fixes a workflow syntax error and pins the Python version to 3.13 to ensure compatibility with future releases.

It addresses a failure in .github/workflows/verify-ensurepip-wheels.yml caused by an invalid workflow_dispatch declaration.

… version number 3.13

Signed-off-by: ioit-aaa <211367176+ioit-aaa@users.noreply.github.com>
@ghost
ghost requested review from pfmoore and pradyunsg as code owners September 24, 2025 13:22
@python-cla-bot

python-cla-bot Bot commented Sep 24, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Sep 24, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ghost

ghost commented Sep 24, 2025

Copy link
Copy Markdown
Author

I contributed this PR simply because the broken workflow was distracting me from playing Genshin Impact. I kept wondering why the syntax error hadn’t been fixed yet, and the Python version was still unspecified. I guess I’m just a bit of a perfectionist.

@ghost

ghost commented Sep 24, 2025

Copy link
Copy Markdown
Author

ince this workflow is tied to the 3.13 branch, it makes sense to explicitly pin the Python version to 3.13 instead of using a generic 3. This ensures the checks reflect the actual runtime context of the branch.

@picnixz

picnixz commented Sep 24, 2025

Copy link
Copy Markdown
Member

I don't think it's an issue. We can have an empty workflow_dispatch like that. As for pinning the Python version, I don't think it's necessary. If you believe it is an issue, please open one.

@picnixz picnixz closed this Sep 24, 2025
@picnixz

picnixz commented Sep 24, 2025

Copy link
Copy Markdown
Member

ince this workflow is tied to the 3.13 branch, it makes sense to explicitly pin the Python version to 3.13 instead of using a generic 3. This ensures the checks reflect the actual runtime context of the branch.

The workflow is not tied to Python 3.13. This is a workflow for checking wheels, so it doesn't matter which Python is used, as soon as the latter is compatible with the script.

@ghost

ghost commented Sep 24, 2025

Copy link
Copy Markdown
Author

ince this workflow is tied to the 3.13 branch, it makes sense to explicitly pin the Python version to 3.13 instead of using a generic 3. This ensures the checks reflect the actual runtime context of the branch.

The workflow is not tied to Python 3.13. This is a workflow for checking wheels, so it doesn't matter which Python is used, as soon as the latter is compatible with the script.

I understand that the script may run fine on any compatible Python version, but since this workflow lives on the 3.13 branch, explicitly pinning Python 3.13 helps reinforce semantic clarity and avoids ambiguity in future maintenance.

@picnixz

picnixz commented Sep 24, 2025

Copy link
Copy Markdown
Member

The workflow lives in every branch. It doesn't help future maintenance as we'll need to change each branch with the corresponding Python version and backport this, which is extra work. Some workflows need specific Python versions because of the script they use though and this is fine. But this one doesn't need Python 3.13 explicitly and it's better to use the default Python of the image.

@ghost

ghost commented Sep 24, 2025

Copy link
Copy Markdown
Author

The workflow lives in every branch. It doesn't help future maintenance as we'll need to change each branch with the corresponding Python version and backport this, which is extra work. Some workflows need specific Python versions because of the script they use though and this is fine. But this one doesn't need Python 3.13 explicitly and it's better to use the default Python of the image.

Thank you for your explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant