gh-138542: error message is wrong when inspect a custom module#138543
Closed
yihong0618 wants to merge 8 commits into
Closed
gh-138542: error message is wrong when inspect a custom module#138543yihong0618 wants to merge 8 commits into
yihong0618 wants to merge 8 commits into
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
sobolevn
reviewed
Sep 6, 2025
Co-authored-by: sobolevn <mail@sobolevn.me>
Contributor
Author
|
@sobolevn Thank you very much I learned how to apply suggestions batch! |
sobolevn
reviewed
Sep 7, 2025
Co-authored-by: sobolevn <mail@sobolevn.me>
Contributor
Author
|
@sobolevn Thank you very much |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
reviewed
Sep 7, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as diff and issues
for build-in module there's a
object.__spec__this patch make the error message better.