-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-136437: Make several functions in os.path
pos-only
#136949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not it update also samestat
, samefile
, maybe other functions in genericpath
?
Yes, I missed |
I created #136970 to fix first |
Merged. A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks everyone! Will leave open till tomorrow and merge :) |
Marking functions from #136812 and #136946 as accepting pos-only.
Not to be backported.
os.path
documentation vs. runtime #136437