Skip to content

Remove duplicate comment in Lib/test/test_platform.py#136835

Closed
ShaharNaveh wants to merge 2 commits into
python:mainfrom
ShaharNaveh:typo-test-platform
Closed

Remove duplicate comment in Lib/test/test_platform.py#136835
ShaharNaveh wants to merge 2 commits into
python:mainfrom
ShaharNaveh:typo-test-platform

Conversation

@ShaharNaveh

Copy link
Copy Markdown
Contributor

No description provided.

@python-cla-bot

python-cla-bot Bot commented Jul 19, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Jul 19, 2025
@bedevere-app

This comment was marked as resolved.

@StanFromIreland StanFromIreland changed the title Remove typo comment in Lib/test/test_platform.py Remove duplicate comment in Lib/test/test_platform.py Jul 19, 2025
@StanFromIreland

Copy link
Copy Markdown
Member

Please sign the CLA.

I changed the title slightly as it sounds as if you are removing the comment because there is an error, not fixing it.

@ShaharNaveh

Copy link
Copy Markdown
Contributor Author

Please sign the CLA.

Just did:)

I changed the title slightly as it sounds as if you are removing the comment because there is an error, not fixing it.

Thanks!

@ShaharNaveh

Copy link
Copy Markdown
Contributor Author

@StanFromIreland friendly ping

picnixz
picnixz previously approved these changes Jul 25, 2025
@picnixz picnixz dismissed their stale review July 25, 2025 16:03

I'm still thinking about

@picnixz

picnixz commented Jul 25, 2025

Copy link
Copy Markdown
Member

Ah I don't remember whether we usually accept those typos or not.

@AA-Turner I usually accept them when they are in Lib/* because someone could be looking at the source (and sometimes is useful) but I don't remember for Lib/test/*. Maybe we should rather remove the comment once we change this file?

@AA-Turner

Copy link
Copy Markdown
Member

Yep, this is just churn.

@AA-Turner AA-Turner closed this Jul 25, 2025
@picnixz

picnixz commented Jul 25, 2025

Copy link
Copy Markdown
Member

FTR, I've also looked at the recent commits concerning typos and none of them were about grammatical typos in Lib/test (those in Lib/test were improvements for filtering). Ideally this would require to be backported to prevent future conflicts, but since 3.14 is in RC1 it wouldn't be so it's indeed better not to fix this typo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants