Enable Windows on Arm GitHub runners #131559
Conversation
diegorusso
requested review from
brandtbucher,
savannahostrowski,
ezio-melotti,
hugovk and
AA-Turner
as code owners
diegorusso
added
skip issue
skip news
infra
diegorusso
force-pushed
the
windows-aarch64-runners
branch
from
77d3e04 to
c3f95a3
Compare
|
Exciting! I think the JIT failure should be fixed on |
|
...looks like JIT builds were broken again. |
AA-Turner
changed the title
.github/workflows/build.yml
Outdated
| @@ -164,10 +164,10 @@ jobs: | |||
| - false | |||
| - true | |||
| include: | |||
| - os: windows-latest # FIXME(diegorusso): change to os: windows-aarch64 | |||
| - os: windows-aarch64 | |||
There was a problem hiding this comment.
Good point. At the moment these are available on selected projects for now. I'm not sure when they will be in GA. I will ask and report back.
I'll add something to skip the aarch64 on forks.
There was a problem hiding this comment.
Can you double check if you have Windows runners available on forks without my patch? See here: https://github.com/diegorusso/cpython/actions/runs/14119011738
There was a problem hiding this comment.
Also CIFuzz are skipped.
There was a problem hiding this comment.
Yes, I do have Windows runners on forks without this patch, here's main and a branch from main:
- https://github.com/hugovk/cpython/actions/runs/14126514909
- https://github.com/hugovk/cpython/actions/runs/14126621995
Note #131702 was merged 3 days ago to fix a Windows skip when running on main, and I don't think we have that here yet? Let's first update this PR from main and re-check.
There was a problem hiding this comment.
Ah maybe I need to rebase the branch then.
There was a problem hiding this comment.
Have a look now.
diegorusso
force-pushed
the
windows-aarch64-runners
branch
2 times, most recently
from
152c36b to
3388831
Compare
diegorusso
requested review from
brettcannon,
freakboy3742,
ericsnowcurrently,
erlend-aasland,
barneygale,
corona10,
ethanfurman,
JelleZijlstra and
AlexWaygood
as code owners
picnixz
removed request for
brettcannon,
carljm,
gpshead,
methane,
warsaw,
1st1,
asvetlov,
tiran,
JelleZijlstra,
barneygale,
ncoghlan,
iritkatriel,
ericsnowcurrently,
pganssle,
rhettinger,
willingc,
corona10,
ethanfurman,
savannahostrowski,
markshannon,
picnixz,
pablogsal,
erlend-aasland,
lysnikolaou,
ezio-melotti,
Fidget-Spinner,
brandtbucher,
kumaraditya303,
AlexWaygood and
abalkin
I had to put some if conditions in different steps because these runners are not generally available hence skipping checks on forks.